From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbvhK-00028d-RK for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:25:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbvhI-0003xt-Eq for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:24:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42866) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbvhH-0003xc-O9 for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:24:56 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TEOsgk018091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 10:24:54 -0400 Date: Wed, 29 Jun 2011 16:24:42 +0200 From: Alon Levy Message-ID: <20110629142442.GX30873@bow.redhat.com> References: <1309348641-20061-1-git-send-email-alevy@redhat.com> <1309348641-20061-9-git-send-email-alevy@redhat.com> <4E0B222A.50501@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0B222A.50501@redhat.com> Subject: Re: [Qemu-devel] [PATCHv3] qxl: update and add debug prints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Wed, Jun 29, 2011 at 03:01:30PM +0200, Gerd Hoffmann wrote: > Hi, > > >- dprint(d, 1, "%s: done\n", __FUNCTION__); > >+ dprint(d, 1, "%s: done (num_free_res %d, %p)\n", __FUNCTION__, > >+ d->num_free_res, d->last_release); > > > case QXL_IO_RESET: > >- dprint(d, 1, "QXL_IO_RESET\n"); > >+ dprint(d, 1, "QXL_IO_RESET %d (%p)\n", d->num_free_res, > >+ d->last_release); > > Hmm, this looks pretty much like something added to debug a specific > issue, not something useful for tracing in general ... ok. can you just drop it from the queue so I can avoid sending a v4? > > cheers, > Gerd >