From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string
Date: Wed, 29 Jun 2011 16:25:43 +0200 [thread overview]
Message-ID: <20110629142543.GY30873@bow.redhat.com> (raw)
In-Reply-To: <4E0B22A4.1000802@redhat.com>
On Wed, Jun 29, 2011 at 03:03:32PM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >- dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", __FUNCTION__, io_port);
> >+ dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
> >+ __FUNCTION__, io_port, io_port_to_string(io_port));
>
> Is this worth it? Should be a quite rare event ...
well, it's helpful for debugging, so I don't see why not. The extra code is not that large,
and it's already written :)
>
> cheers,
> Gerd
>
next prev parent reply other threads:[~2011-06-29 14:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 11:57 [Qemu-devel] [PATCHv3] qxl S3&S4 (suspend and hibernate) support Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] async io: suggested fixes Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] async thread fix - handle EAGAIN/EINTR, remove fprintf Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: use track_lock instead of wlock for guest_surfaces Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add mode to debugprint on destroy primary Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: allow QXL_IO_LOG also in vga Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: abort on panic instead of exit Alon Levy
2011-06-29 12:44 ` Gerd Hoffmann
2011-06-29 14:24 ` Alon Levy
2011-06-29 14:34 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl-logger: add timestamp to command log Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: update and add debug prints Alon Levy
2011-06-29 13:01 ` Gerd Hoffmann
2011-06-29 14:24 ` Alon Levy
2011-06-29 14:36 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add dev id to guest prints Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add io_port_to_string Alon Levy
2011-06-29 13:03 ` Gerd Hoffmann
2011-06-29 14:25 ` Alon Levy [this message]
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: update revision to QXL_REVISION_STABLE_V10 Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support Alon Levy
2011-06-29 13:06 ` Gerd Hoffmann
2011-06-29 14:27 ` Alon Levy
2011-06-29 14:50 ` Gerd Hoffmann
2011-06-29 18:22 ` Alon Levy
2011-06-29 14:45 ` Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on DESTROY_ALL_SURFACES{, _ASYNC} Alon Levy
2011-06-29 13:09 ` Gerd Hoffmann
2011-06-29 14:29 ` Alon Levy
2011-06-29 15:00 ` Gerd Hoffmann
2011-06-29 18:28 ` Alon Levy
2011-06-30 7:16 ` Gerd Hoffmann
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode Alon Levy
2011-06-29 11:57 ` [Qemu-devel] [PATCHv3] (alon-local) symlink bios out of tree Alon Levy
2011-06-29 13:11 ` Gerd Hoffmann
2011-06-29 14:31 ` Alon Levy
2011-06-29 15:01 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2011-07-12 13:55 [Qemu-devel] [PATCHv3] async + suspend reworked Alon Levy
2011-07-12 13:55 ` [Qemu-devel] [PATCHv3] qxl: add io_port_to_string Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629142543.GY30873@bow.redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).