From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbviJ-0002SR-64
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:26:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbviH-00047r-0z
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:25:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbviG-00047c-Lw
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:25:56 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TEPtCf031476
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 10:25:55 -0400
Date: Wed, 29 Jun 2011 16:25:43 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110629142543.GY30873@bow.redhat.com>
References: <1309348641-20061-1-git-send-email-alevy@redhat.com>
	<1309348641-20061-11-git-send-email-alevy@redhat.com>
	<4E0B22A4.1000802@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E0B22A4.1000802@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add io_port_to_string
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Wed, Jun 29, 2011 at 03:03:32PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >-        dprint(d, 1, "%s: unexpected port 0x%x in vga mode\n", __FUNCTION__, io_port);
> >+        dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n",
> >+            __FUNCTION__, io_port, io_port_to_string(io_port));
> 
> Is this worth it?  Should be a quite rare event ...

well, it's helpful for debugging, so I don't see why not. The extra code is not that large,
and it's already written :)

> 
> cheers,
>   Gerd
>