From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvkJ-0002xS-RF
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:28:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvkI-0004Y8-20
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:28:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvkH-0004Xf-I1
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:28:01 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TES0kF031936
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 10:28:00 -0400
Date: Wed, 29 Jun 2011 16:27:47 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110629142747.GZ30873@bow.redhat.com>
References: <1309348641-20061-1-git-send-email-alevy@redhat.com>
	<1309348641-20061-13-git-send-email-alevy@redhat.com>
	<4E0B2359.7000702@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E0B2359.7000702@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES,
 RELEASE} for guest S3&S4 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Wed, Jun 29, 2011 at 03:06:33PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >+    case QXL_IO_FLUSH_SURFACES:
> >+        dprint(d, 1, "QXL_IO_FLUSH_SURFACES (%d) entry (%s, s#=%d, res#=%d)\n",
> >+            val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> >+            d->num_free_res);
> >+        qemu_spice_stop(&d->ssd);
> >+        qemu_spice_start(&d->ssd);
> >+        dprint(d, 1, "QXL_IO_FLUSH_SURFACES exit (%s, s#=%d, res#=%d,%p)\n",
> >+            qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> >+            d->num_free_res, d->last_release);
> >+        break;
> 
> This should be async as we'll go sleep and wait for the spice server
> thread finish in qemu_spice_stop().

Yeah, I meant to do that, forgot, thanks for catching it.

> 
> >+    case QXL_IO_FLUSH_RELEASE: {
> >+        QXLReleaseRing *ring =&d->ram->release_ring;
> >+        if (ring->prod - ring->cons + 1 == ring->num_items) {
> >+            // TODO - "return" a value to the guest and let it loop?
>                   ^^^^
> Hmm.
So the story goes: I wrote this, but didn't actually see this happen in practice,
particularily since the driver empties the release ring. The simplest would be to
replace it with some fprintf(stderr)

> 
> cheers,
>   Gerd