From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40228)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvmO-0003Xr-W5
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:30:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvmM-00055M-Gw
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:30:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QbvmL-00054h-VP
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 10:30:10 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TEU8Mq011823
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 10:30:08 -0400
Date: Wed, 29 Jun 2011 16:29:56 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110629142956.GA30873@bow.redhat.com>
References: <1309348641-20061-1-git-send-email-alevy@redhat.com>
	<1309348641-20061-14-git-send-email-alevy@redhat.com>
	<4E0B2410.3090008@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E0B2410.3090008@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3] qxl: move to UNDEFINED on
	DESTROY_ALL_SURFACES{, _ASYNC}
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Wed, Jun 29, 2011 at 03:09:36PM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >+    case QXL_IO_DESTROY_ALL_SURFACES_ASYNC:
> >+        d->mode = QXL_MODE_UNDEFINED;
> 
> Should go to the async thread.

doesn't it make more sense to do all state changes from the vcpu thread? async thread can run much
later, if you have a QXL_IO_DESTROY_ALL_SURFACES_ASYNC followed by a QXL_IO_CREATE_PRIMARY_ASYNC where
the driver did not wait for the completion of the ASYNC first, I would still like to support that,
but it won't work if I move this to the async thread.

> 
> cheers,
>   Gerd