From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qc12c-0005Ui-KS
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:07:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qc12b-0004su-07
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:07:18 -0400
Received: from mail-fx0-f47.google.com ([209.85.161.47]:38786)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Qc12a-0004sj-HL
	for qemu-devel@nongnu.org; Wed, 29 Jun 2011 16:07:16 -0400
Received: by fxg11 with SMTP id 11so1712088fxg.34
	for <qemu-devel@nongnu.org>; Wed, 29 Jun 2011 13:07:15 -0700 (PDT)
Date: Wed, 29 Jun 2011 22:07:11 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110629200711.GA32548@laped.lan>
References: <1309373591-30380-1-git-send-email-peter.maydell@linaro.org>
	<1309373591-30380-3-git-send-email-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1309373591-30380-3-git-send-email-peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about
 some writes to r/o registers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, Juha =?iso-8859-1?Q?Riihim=E4ki?= <juha.riihimaki@nokia.com>, qemu-devel@nongnu.org, patches@linaro.org

On Wed, Jun 29, 2011 at 07:53:10PM +0100, Peter Maydell wrote:
> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
> kernel will do them anyway.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Hi Peter,

I usually find this kind of logs useful.
Maybe we should turn them into _log_mask(~0, xxx) so they only come out
when -d is enabled?

Cheers


> ---
>  hw/omap_gpio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/omap_gpio.c b/hw/omap_gpio.c
> index 478f7d9..b53b13b 100644
> --- a/hw/omap_gpio.c
> +++ b/hw/omap_gpio.c
> @@ -385,7 +385,7 @@ static void omap2_gpio_module_write(void *opaque, target_phys_addr_t addr,
>      case 0x00:	/* GPIO_REVISION */
>      case 0x14:	/* GPIO_SYSSTATUS */
>      case 0x38:	/* GPIO_DATAIN */
> -        OMAP_RO_REG(addr);
> +        /* read-only, ignore quietly */
>          break;
>  
>      case 0x10:	/* GPIO_SYSCONFIG */
> @@ -531,7 +531,7 @@ static void omap2_gpio_module_writep(void *opaque, target_phys_addr_t addr,
>      case 0x00:	/* GPIO_REVISION */
>      case 0x14:	/* GPIO_SYSSTATUS */
>      case 0x38:	/* GPIO_DATAIN */
> -        OMAP_RO_REG(addr);
> +        /* read-only, ignore quietly */
>          break;
>  
>      case 0x10:	/* GPIO_SYSCONFIG */
> -- 
> 1.7.1
> 
>