Re: [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation

[Luiz Capitulino <lcapitulino@redhat.com>]

On Fri, 01 Jul 2011 09:16:38 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > Some constructions in that function have broken indentation. Fix them.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  blockdev.c |   52 ++++++++++++++++++++++++++--------------------------
> >  1 files changed, 26 insertions(+), 26 deletions(-)
> >
> > diff --git a/blockdev.c b/blockdev.c
> > index 7d579d6..27bf68a 100644
> > --- a/blockdev.c
> > +++ b/blockdev.c
> > @@ -272,23 +272,23 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
> >          if (type == IF_COUNT) {
> >              error_report("unsupported bus type '%s'", buf);
> >              return NULL;
> > -	}
> > +	    }
> 
> Old indentation is correct, apart from tabs.
> 
> New indentation is incorrect, and fails to remove tabs.
> 
>         if (type == IF_COUNT) {
>             error_report("unsupported bus type '%s'", buf);
>             return NULL;
> 	    }
> ^^^^^^^^    ^
> tab here    incorrect indentation

Yeah, I realized that after Stefan's comment.

> Check your editor settings.
> 
> I don't see "broken" indentation anywhere in this function.  A few lines
> are off: indented 3 instead of 4.  If we want to fix such things, I'd
> prefer it done globally.

Ok, I'll drop this patch from the series then and let to do it globally
later.