From: Amit Shah <amit.shah@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
mdroth@linux.vnet.ibm.com, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] 80-column rule and breaking output statements
Date: Mon, 4 Jul 2011 11:35:50 +0530 [thread overview]
Message-ID: <20110704060550.GA3182@amit-x200.redhat.com> (raw)
In-Reply-To: <CAJSP0QX5N2G6UhG8DfztQtT95dMng2NqY34tf0piZRLcvWRmvA@mail.gmail.com>
On (Sat) 02 Jul 2011 [09:38:30], Stefan Hajnoczi wrote:
...
> I don't see split lines as an issue because I never grep for an entire
> line. Pick a small, unique, fixed part of the message and you'll find
> it.
>
> "Small" in order to avoid any formatting or split line issues.
Unless you pick your Small string that was split across multiple lines.
> "Unique" in order to cut down the number of grep results.
> "Fixed" in order to avoid format string expansions as Blue Swirl mentioned.
Amit
prev parent reply other threads:[~2011-07-04 6:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 16:38 [Qemu-devel] [PATCH] virtio-serial: Fix segfault on guest boot Luiz Capitulino
2011-06-17 6:47 ` Amit Shah
2011-06-17 7:47 ` Markus Armbruster
2011-06-17 8:44 ` Amit Shah
2011-06-17 13:16 ` Luiz Capitulino
2011-06-17 13:21 ` Luiz Capitulino
2011-06-17 16:09 ` Amit Shah
2011-06-17 18:08 ` Luiz Capitulino
2011-06-18 3:42 ` Amit Shah
2011-06-18 21:43 ` Blue Swirl
2011-06-22 4:53 ` Amit Shah
2011-06-26 17:43 ` Blue Swirl
2011-06-27 9:48 ` [Qemu-devel] 80-column rule and breaking output statements Amit Shah
2011-07-01 19:43 ` Blue Swirl
2011-07-02 8:38 ` Stefan Hajnoczi
2011-07-04 6:05 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704060550.GA3182@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).