From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60462)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QekDC-0001E0-CX
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 04:45:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QekDA-0002w0-OB
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 04:45:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QekDA-0002vr-6n
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 04:45:28 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p678jQH8030688
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 7 Jul 2011 04:45:26 -0400
Date: Thu, 7 Jul 2011 10:45:19 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110707084519.GS20603@bow.redhat.com>
References: <1309954766-9728-1-git-send-email-alevy@redhat.com>
	<1309954766-9728-6-git-send-email-alevy@redhat.com>
	<4E1562B6.9030500@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E1562B6.9030500@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out
 of qxl_add_memslot
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Thu, Jul 07, 2011 at 09:39:34AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >-static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta)
> >+static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t delta,
> >+                            QXLDevMemSlot *memslot)
> 
> >-        qxl_add_memslot(d, val, 0);
> >+        qxl_add_memslot(d, val, 0,&memslot);
> >+        qemu_spice_add_memslot(&d->ssd,&memslot);
> 
> Do we still need this and the simliar patches?  Given that we don't
> call qemu_spice_add_memslot() from another thread any more we could
> just pass in a async flag to qxl_add_memslot().

I will. The most changes needed are to split the part after calling worker to a complete call,
I'm storing the io data inside PCIQXLDevice.

> 
> cheers,
>   Gerd
> 
>