[Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

[Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

[Luiz Capitulino]

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qemu-options.hx |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index e6d7adc..5f16a78 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -160,6 +160,11 @@ an untrusted format header.
 This option specifies the serial number to assign to the device.
 @item addr=@var{addr}
 Specify the controller's PCI address (if=virtio only).
+@item werror=@var{action},rerror=@var{action}
+Specify which @var{action} to take on write and read errors. Valid actions are:
+"ignore" (ignore the error and try to continue), "stop" (pause QEMU),
+"enospc" (pause QEMU, but only on no space conditions),
+"report" (report the error to the guest).
 @end table
 
 By default, writethrough caching is used for all block device.  This means that
-- 
1.7.6.134.gcf13f

Re: [Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

[Kevin Wolf]

Am 07.07.2011 18:04, schrieb Luiz Capitulino:
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qemu-options.hx |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index e6d7adc..5f16a78 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -160,6 +160,11 @@ an untrusted format header.
>  This option specifies the serial number to assign to the device.
>  @item addr=@var{addr}
>  Specify the controller's PCI address (if=virtio only).
> +@item werror=@var{action},rerror=@var{action}
> +Specify which @var{action} to take on write and read errors. Valid actions are:
> +"ignore" (ignore the error and try to continue), "stop" (pause QEMU),
> +"enospc" (pause QEMU, but only on no space conditions),

Maybe "pause QEMU only if the host disk is full; report the error to the
guest otherwise"?

> +"report" (report the error to the guest).
>  @end table
>  
>  By default, writethrough caching is used for all block device.  This means that

We should mention that werror=enospc and rerror=report is the default.

Kevin

Re: [Qemu-devel] [PATCH] qemu-options.hx: Document werror and rerror -drive options

[Luiz Capitulino]

On Fri, 08 Jul 2011 10:18:17 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 07.07.2011 18:04, schrieb Luiz Capitulino:
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qemu-options.hx |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index e6d7adc..5f16a78 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -160,6 +160,11 @@ an untrusted format header.
> >  This option specifies the serial number to assign to the device.
> >  @item addr=@var{addr}
> >  Specify the controller's PCI address (if=virtio only).
> > +@item werror=@var{action},rerror=@var{action}
> > +Specify which @var{action} to take on write and read errors. Valid actions are:
> > +"ignore" (ignore the error and try to continue), "stop" (pause QEMU),
> > +"enospc" (pause QEMU, but only on no space conditions),
> 
> Maybe "pause QEMU only if the host disk is full; report the error to the
> guest otherwise"?

Works for me.

> > +"report" (report the error to the guest).
> >  @end table
> >  
> >  By default, writethrough caching is used for all block device.  This means that
> 
> We should mention that werror=enospc and rerror=report is the default.

I did that in my first private first, but I dropped when I realized that
we don't document defaults for the other options.