From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52660)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QfAVF-0007uY-Uc
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:49:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QfAVE-00054I-2Q
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:49:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QfAVD-000543-EV
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:49:51 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p68Cnom3029659
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 8 Jul 2011 08:49:50 -0400
Date: Fri, 8 Jul 2011 09:49:48 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110708094948.22446f1b@doriath>
In-Reply-To: <4E16BD49.80708@redhat.com>
References: <20110707130449.5618db41@doriath>
	<4E16BD49.80708@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-options.hx: Document werror and
 rerror -drive options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On Fri, 08 Jul 2011 10:18:17 +0200
Kevin Wolf <kwolf@redhat.com> wrote:

> Am 07.07.2011 18:04, schrieb Luiz Capitulino:
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qemu-options.hx |    5 +++++
> >  1 files changed, 5 insertions(+), 0 deletions(-)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index e6d7adc..5f16a78 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -160,6 +160,11 @@ an untrusted format header.
> >  This option specifies the serial number to assign to the device.
> >  @item addr=@var{addr}
> >  Specify the controller's PCI address (if=virtio only).
> > +@item werror=@var{action},rerror=@var{action}
> > +Specify which @var{action} to take on write and read errors. Valid actions are:
> > +"ignore" (ignore the error and try to continue), "stop" (pause QEMU),
> > +"enospc" (pause QEMU, but only on no space conditions),
> 
> Maybe "pause QEMU only if the host disk is full; report the error to the
> guest otherwise"?

Works for me.

> > +"report" (report the error to the guest).
> >  @end table
> >  
> >  By default, writethrough caching is used for all block device.  This means that
> 
> We should mention that werror=enospc and rerror=report is the default.

I did that in my first private first, but I dropped when I realized that
we don't document defaults for the other options.