From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33362)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgNCr-00037S-Dt
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:35:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgNCo-0006fZ-Tb
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:35:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1QgNCo-0006fL-CS
	for qemu-devel@nongnu.org; Mon, 11 Jul 2011 16:35:50 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6BKZmoI006416
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 11 Jul 2011 16:35:48 -0400
Date: Mon, 11 Jul 2011 17:35:46 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110711173546.71bdc33c@doriath>
In-Reply-To: <4E1B5D09.6050403@redhat.com>
References: <1310407269-13203-1-git-send-email-Jes.Sorensen@redhat.com>
	<20110711172456.5f61adbb@doriath> <4E1B5D09.6050403@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 11 Jul 2011 22:28:57 +0200
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:

> On 07/11/11 22:24, Luiz Capitulino wrote:
> > On Mon, 11 Jul 2011 20:01:09 +0200
> > Jes.Sorensen@redhat.com wrote:
> > 
> >> > From: Jes Sorensen <Jes.Sorensen@redhat.com>
> >> > 
> >> > Add QMP bits for snapshot_blkdev command. This is the same as
> >> > snapshot_blkdev in the human monitor. The command is synchronous.
> >> > 
> >> > In the future async commands and or a break down of the functionality
> >> > into multiple commands might be added.
> >> > 
> >> > Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> >> > ---
> >> >  qmp-commands.hx |   35 +++++++++++++++++++++++++++++++++++
> >> >  1 files changed, 35 insertions(+), 0 deletions(-)
> >> > 
> >> > diff --git a/qmp-commands.hx b/qmp-commands.hx
> >> > index 92c5c3a..2b9f6af 100644
> >> > --- a/qmp-commands.hx
> >> > +++ b/qmp-commands.hx
> >> > @@ -694,6 +694,41 @@ Example:
> >> >  EQMP
> >> >  
> >> >      {
> >> > +        .name       = "blockdev-snapshot-sync",
> >> > +        .args_type  = "device:B,snapshot-file:s?,format:s?",
> > You changed from an underline to a hyphen as I asked, but the implementation
> > still expects an underline. I fixed that myself to avoid multiple submissions
> > because of a small thing (also fixed the command name in the subject).
> > 
> > The patch I merged follows for reference. Please, test your patches before
> > submitting next time.
> > 
> > 
> 
> Sorry that is no go, you just broke the hmp implementation - you cannot
> change the hmp behavior like that.

HMP uses positional arguments, so changing argument names makes no
difference. And, apart from some exceptions, it's not an stable interface,
anyway...