From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43468)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qgcyg-0007N5-NY
	for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:26:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qgcyf-0002HH-5E
	for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:26:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Qgcye-0002H8-Hn
	for qemu-devel@nongnu.org; Tue, 12 Jul 2011 09:26:16 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6CDQEna021199
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 12 Jul 2011 09:26:15 -0400
Date: Tue, 12 Jul 2011 10:26:13 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110712102613.75780891@doriath>
In-Reply-To: <4E1C1331.6060007@redhat.com>
References: <1310407269-13203-1-git-send-email-Jes.Sorensen@redhat.com>
	<20110711172456.5f61adbb@doriath> <4E1B5D09.6050403@redhat.com>
	<20110711173546.71bdc33c@doriath> <4E1C1331.6060007@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] QMP: add snapshot_blkdev command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, 12 Jul 2011 11:26:09 +0200
Jes Sorensen <Jes.Sorensen@redhat.com> wrote:

> On 07/11/11 22:35, Luiz Capitulino wrote:
> >> Sorry that is no go, you just broke the hmp implementation - you cannot
> >> > change the hmp behavior like that.
> > HMP uses positional arguments, so changing argument names makes no
> > difference. And, apart from some exceptions, it's not an stable interface,
> > anyway...
> > 
> 
> I guess you're right about the naming not affecting the hmp interface.
> However hmp is far more usable to end users than qmp, so yes it does
> matter not to change the interface at random.

Right, but we don't do it at random. Actually, it's not something that
happens often and we always consider the impact. However, hmp doesn't
have stability guarantees as qmp has.

In this specific case, no hmp user visible change has been made.