From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39121)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheIe-0008M6-Ts
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:03:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheIe-0008AK-1W
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:03:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36867)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheId-0008AG-N6
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:03:08 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6F9360O019441
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 05:03:06 -0400
Date: Fri, 15 Jul 2011 12:02:43 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110715090243.GJ23682@bow.tlv.redhat.com>
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-6-git-send-email-alevy@redhat.com>
	<4E1FF359.2070306@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E1FF359.2070306@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 05/12] qxl: add io_port_to_string
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Fri, Jul 15, 2011 at 09:59:21AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> >+    switch (io_port) {
> >+    case QXL_IO_NOTIFY_CMD:
> >+        return "QXL_IO_NOTIFY_CMD";
> 
> Wasn't the plan to make this an array?
> 

yes. Somehow I sent the wrong patch. No idea how I managed to do that.

> cheers,
>   Gerd
>