From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33667)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheM4-0000hg-6n
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:06:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheM2-0000LK-DS
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:06:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6221)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheM1-0000LE-Vk
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:06:38 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6F96bPs014656
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 05:06:37 -0400
Date: Fri, 15 Jul 2011 12:06:13 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110715090613.GL23682@bow.tlv.redhat.com>
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-10-git-send-email-alevy@redhat.com>
	<4E1FF80F.70601@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E1FF80F.70601@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 09/12] qxl: async io support using new
	spice api
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Fri, Jul 15, 2011 at 10:19:27AM +0200, Gerd Hoffmann wrote:
> On 07/14/11 21:13, Alon Levy wrote:
> >Some of the QXL port i/o commands are waiting for the spice server to
> >complete certain actions.  Add async versions for these commands, so we
> >don't block the vcpu while the spice server processses the command.
> >Instead the qxl device will raise an IRQ when done.
> >
> >The async command processing relies on an added QXLInterface::async_complete
> >and added QXLWorker::*_async additions, in spice server qxl>= 3.1
> 
> Applying: qxl: async io support using new spice api
> === checkpatch complains ===
> WARNING: labels should not be indented
> #320: FILE: hw/qxl.c:1207:
> +    async_common:
> 

thanks, my bad, did this after the checkpatch (obviously). I'll go add
it to the commit hook.

> total: 0 errors, 1 warnings, 574 lines checked
> 
> cheers,
>   Gerd