From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37544)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheRT-0001xk-RR
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:12:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheRQ-00010u-4g
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:12:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1QheRO-00010Y-N7
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:12:11 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6F9C9lR030508
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 05:12:09 -0400
Date: Fri, 15 Jul 2011 12:11:43 +0300
From: Alon Levy <alevy@redhat.com>
Message-ID: <20110715091143.GM23682@bow.tlv.redhat.com>
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-11-git-send-email-alevy@redhat.com>
	<4E1FF71E.4090607@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E1FF71E.4090607@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 10/12] qxl: add QXL_IO_FLUSH_{SURFACES,
 RELEASE} for guest S3&S4 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: yhalperi@redhat.com, qemu-devel@nongnu.org

On Fri, Jul 15, 2011 at 10:15:26AM +0200, Gerd Hoffmann wrote:
> >+#if SPICE_INTERFACE_QXL_MINOR>= 1
> >+    case QXL_IO_FLUSH_RELEASE: {
> >+        QXLReleaseRing *ring =&d->ram->release_ring;
> >+        if (ring->prod - ring->cons + 1 == ring->num_items) {
> >+            fprintf(stderr,
> >+                "ERROR: no flush, full release ring [p%d,%dc]\n",
> >+                ring->prod, ring->cons);
> >+        }
> >+        qxl_push_free_res(d, 1 /* flush */);
> >+        dprint(d, 1, "QXL_IO_FLUSH_RELEASE exit (%s, s#=%d, res#=%d,%p)\n",
> >+            qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> >+            d->num_free_res, d->last_release);
> >+        break;
> >+    }
> >+    case QXL_IO_FLUSH_SURFACES_ASYNC:
> >+        dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
> >+               val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> >+               d->num_free_res);
> >+        qxl_spice_flush_surfaces_async(d);
> >+#endif
> >+        break;
> 
> The last two lines should be swapped I guess.
> Doesn't harm, but looks a bit odd ...

yep. thanks, will fix.

> 
> cheers,
>   Gerd
>