From: Stefan Hajnoczi <stefanha@gmail.com>
To: Lluís <xscript@gmx.net>
Cc: qemu-devel@nongnu.org, chouteau@adacore.com
Subject: Re: [Qemu-devel] [PATCH v5 04/10] trace-state: separate trace event control and query routines from the simple backend
Date: Fri, 15 Jul 2011 10:41:30 +0100 [thread overview]
Message-ID: <20110715094130.GD6856@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20110628165321.23482.80961.stgit@ginnungagap.bsc.es>
On Tue, Jun 28, 2011 at 06:53:21PM +0200, Lluís wrote:
> Move the 'st_print_trace_events' and 'st_change_trace_event_state' into
> backend-agnostic 'trace_print_events' and 'trace_event_set_state' (respectively)
> in the "trace/control.c" file.
Renaming the functions makes sense but moving their implementations out
into control.c inside an #ifdef is not clean. Why not keep their
implementations in simple.c?
Just renaming them to the generic name should be enough. Let the linker
do the #ifdef (we only link in simple.o or we link in another trace
backend). There's no need for control.c.
Stefan
next prev parent reply other threads:[~2011-07-15 9:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 16:52 [Qemu-devel] [PATCH v5 00/10] trace-state: make the behaviour of "disable" consistent across all backends Lluís
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 01/10] trace: move backend-specific code into the trace/ directory Lluís
2011-07-15 9:40 ` Stefan Hajnoczi
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 02/10] trace: avoid conditional code compilation during option parsing Lluís
2011-07-15 9:41 ` Stefan Hajnoczi
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 03/10] trace: generalize the "property" concept in the trace-events file Lluís
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 04/10] trace-state: separate trace event control and query routines from the simple backend Lluís
2011-07-15 9:41 ` Stefan Hajnoczi [this message]
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 05/10] trace-state: always compile support for controlling and querying trace event states Lluís
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 06/10] trace-state: add "-trace events" argument to control initial state Lluís
2011-07-15 9:40 ` Stefan Hajnoczi
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 07/10] trace-state: always use the "nop" backend on events with the "disable" keyword Lluís
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 08/10] trace-state: [simple] disable all trace points by default Lluís
2011-06-28 16:53 ` [Qemu-devel] [PATCH v5 09/10] trace-state: [stderr] add support for dynamically enabling/disabling events Lluís
2011-06-28 16:54 ` [Qemu-devel] [PATCH v5 10/10] trace: enable all events Lluís
2011-07-12 18:04 ` [Qemu-devel] [PATCH v5 00/10] trace-state: make the behaviour of "disable" consistent across all backends Stefan Hajnoczi
2011-07-15 9:47 ` Stefan Hajnoczi
2011-07-20 19:19 ` Lluís
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110715094130.GD6856@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=chouteau@adacore.com \
--cc=qemu-devel@nongnu.org \
--cc=xscript@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).