From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qhett-0007cZ-Nw for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:41:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qhetr-000692-Nk for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:41:37 -0400 Received: from mail-fx0-f47.google.com ([209.85.161.47]:37754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qhetr-00068p-9P for qemu-devel@nongnu.org; Fri, 15 Jul 2011 05:41:35 -0400 Received: by fxg11 with SMTP id 11so2945245fxg.34 for ; Fri, 15 Jul 2011 02:41:34 -0700 (PDT) Date: Fri, 15 Jul 2011 10:41:30 +0100 From: Stefan Hajnoczi Message-ID: <20110715094130.GD6856@stefanha-thinkpad.localdomain> References: <20110628165254.23482.17825.stgit@ginnungagap.bsc.es> <20110628165321.23482.80961.stgit@ginnungagap.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20110628165321.23482.80961.stgit@ginnungagap.bsc.es> Subject: Re: [Qemu-devel] [PATCH v5 04/10] trace-state: separate trace event control and query routines from the simple backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Cc: qemu-devel@nongnu.org, chouteau@adacore.com On Tue, Jun 28, 2011 at 06:53:21PM +0200, Lluís wrote: > Move the 'st_print_trace_events' and 'st_change_trace_event_state' into > backend-agnostic 'trace_print_events' and 'trace_event_set_state' (respectively) > in the "trace/control.c" file. Renaming the functions makes sense but moving their implementations out into control.c inside an #ifdef is not clean. Why not keep their implementations in simple.c? Just renaming them to the generic name should be enough. Let the linker do the #ifdef (we only link in simple.o or we link in another trace backend). There's no need for control.c. Stefan