From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42190)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Qj9uE-0001VZ-PX
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:00:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Qj9u7-0005B9-5t
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:00:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31233)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1Qj9u6-0005AU-9k
	for qemu-devel@nongnu.org; Tue, 19 Jul 2011 09:00:02 -0400
Date: Tue, 19 Jul 2011 09:56:06 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110719125606.GA29108@amt.cnet>
References: <1310047993-7649-1-git-send-email-joerg.roedel@amd.com>
	<1310047993-7649-3-git-send-email-joerg.roedel@amd.com>
	<20110719114658.GA28500@amt.cnet> <4E257695.4010906@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E257695.4010906@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-x86: Add tsc_freq option to -cpu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On Tue, Jul 19, 2011 at 03:20:37PM +0300, Avi Kivity wrote:
> On 07/19/2011 02:46 PM, Marcelo Tosatti wrote:
> >On Thu, Jul 07, 2011 at 04:13:12PM +0200, Joerg Roedel wrote:
> >>  To let the user configure the desired tsc frequency for the
> >>  guest if running in KVM.
> >>
> >>  Signed-off-by: Joerg Roedel<joerg.roedel@amd.com>
> >>  ---
> >>   target-i386/cpu.h   |    1 +
> >>   target-i386/cpuid.c |   13 +++++++++++++
> >>   2 files changed, 14 insertions(+), 0 deletions(-)
> >>
> >>  diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> >>  index cdf68ff..399e124 100644
> >>  --- a/target-i386/cpu.h
> >>  +++ b/target-i386/cpu.h
> >>  @@ -743,6 +743,7 @@ typedef struct CPUX86State {
> >>       uint32_t cpuid_kvm_features;
> >>       uint32_t cpuid_svm_features;
> >>       bool tsc_valid;
> >>  +    int tsc_khz;
> >
> >This should be saved/restore in migration data (missing VMSTATE entry).
> 
> Why?  It's static data.  Traditionally we only migrate runtime data.
> 
> (although we've been talking about starting a naked qemu and pushing
> all of the configuration from the source).

Right.