From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjB3R-0005jW-Ji for qemu-devel@nongnu.org; Tue, 19 Jul 2011 10:13:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjB3P-0001tv-Ey for qemu-devel@nongnu.org; Tue, 19 Jul 2011 10:13:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjB3O-0001tl-Rj for qemu-devel@nongnu.org; Tue, 19 Jul 2011 10:13:43 -0400 Date: Tue, 19 Jul 2011 16:56:01 +0300 From: "Michael S. Tsirkin" Message-ID: <20110719135601.GA7194@redhat.com> References: <1310901265-32051-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1310901265-32051-1-git-send-email-avi@redhat.com> Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On Sun, Jul 17, 2011 at 02:13:27PM +0300, Avi Kivity wrote: > New in this version: > MemoryRegionOps gained .old_mmio and .old_portio members, which allow > reusing old-style callbacks with the new API. All uses were converted, > except for eepro100.c, which uses the same MemoryRegionOps for both > portio and mmio. Some intermediate patches do introduce dispatching > callbacks, but they are removed later. > > Caveats: > - some devices still grab a global memory region instead of inheriting > it from their bus. Seen in the code as #include "exec-memory.h" Looks good to me. It looks like with this, users of vga_dirty_log_stop like qxl_write_config can go away because the region can stay registered with dirty logging enabled? -- MST