From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjCqo-0005tY-V3 for qemu-devel@nongnu.org; Tue, 19 Jul 2011 12:08:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjCqj-0005G2-NG for qemu-devel@nongnu.org; Tue, 19 Jul 2011 12:08:50 -0400 Received: from verein.lst.de ([213.95.11.211]:52011 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjCqj-0005FS-8g for qemu-devel@nongnu.org; Tue, 19 Jul 2011 12:08:45 -0400 Date: Tue, 19 Jul 2011 18:08:43 +0200 From: Christoph Hellwig Message-ID: <20110719160843.GA3414@lst.de> References: <1311074364-3489-1-git-send-email-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311074364-3489-1-git-send-email-hare@suse.de> Subject: Re: [Qemu-devel] [PATCH][v7] megasas: LSI Megaraid SAS emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hannes Reinecke Cc: Paolo Bonzini , Alexander Graf , qemu-devel@nongnu.org, kvm@vger.kernel.org, Stefan Haynoczi I've mentioned this a few times before, but just to make sure it's not lost: This is a really bad idea for adding to qemu. It's not a controller that actually speaks a plain SCSI protocol to disks, but a RAID controller, that has it's own command set for data plan operation, and minimal support for a few SCSI CDBs around it. I also supports passthrough channels for CDROMs and other periphals, but using those with disks is not recommended by LSI, thus explicitly disabled in most drivers and most certainly not tested. So it fits the qemu model, especially if using scsi-generic undeneath pretty badly and I don't think it helps us in practice.