qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Remove debugging messages.
Date: Tue, 19 Jul 2011 21:59:29 +0100	[thread overview]
Message-ID: <20110719205929.GE2532@amd.home.annexia.org> (raw)
In-Reply-To: <4E25E346.30908@us.ibm.com>

On Tue, Jul 19, 2011 at 03:04:22PM -0500, Anthony Liguori wrote:
> On 07/19/2011 02:23 PM, Richard W.M. Jones wrote:
> >From: "Richard W.M. Jones"<rjones@redhat.com>
> >
> >When using qemu -machine accel=kvm:tcg, if KVM is not available you
> >get a load of debugging output:
> >
> >   Could not access KVM kernel module: No such file or directory
> >   failed to initialize KVM: No such file or directory
> >   Back to tcg accelerator.
> 
> If you ask for kvm, and it can't be initialized, then shouldn't we
> alert the user about this?

That's one way to look at it.

Another is that libguestfs has specified that we want a "best effort".
Give me KVM, if available - great!  If not, I don't really care, give
me TCG.

The -machine option isn't expressive enough to say all these things of
course.

BTW, it seems in 0.15 that the -machine option is now required?  eg in
this case where it seems totally pointless:

$ qemu -nographic -device \?
KVM not supported for this target
No accelerator found!

This resulted in another bug and fix in libguestfs.

http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=d82438431c1551610eb7d9945fa76d6387534582

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

  reply	other threads:[~2011-07-19 20:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19 19:23 [Qemu-devel] [PATCH 1/1] Remove debugging messages Richard W.M. Jones
2011-07-19 19:23 ` [Qemu-devel] [PATCH] " Richard W.M. Jones
2011-07-19 19:47   ` Jan Kiszka
2011-07-19 19:49   ` Michael Tokarev
2011-07-19 20:50     ` Richard W.M. Jones
2011-07-19 20:04   ` Anthony Liguori
2011-07-19 20:59     ` Richard W.M. Jones [this message]
2011-07-19 21:56       ` Anthony Liguori
2011-07-20  8:50         ` Richard W.M. Jones
2011-07-20 12:51           ` Anthony Liguori
2011-07-20 17:38             ` Richard W.M. Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110719205929.GE2532@amd.home.annexia.org \
    --to=rjones@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).