From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjHOD-0007DG-Uh for qemu-devel@nongnu.org; Tue, 19 Jul 2011 16:59:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjHO8-0000SM-Il for qemu-devel@nongnu.org; Tue, 19 Jul 2011 16:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjHO8-0000SG-1j for qemu-devel@nongnu.org; Tue, 19 Jul 2011 16:59:32 -0400 Date: Tue, 19 Jul 2011 21:59:29 +0100 From: "Richard W.M. Jones" Message-ID: <20110719205929.GE2532@amd.home.annexia.org> References: <1311103418-29380-1-git-send-email-rjones@redhat.com> <1311103418-29380-2-git-send-email-rjones@redhat.com> <4E25E346.30908@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E25E346.30908@us.ibm.com> Subject: Re: [Qemu-devel] [PATCH] Remove debugging messages. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Tue, Jul 19, 2011 at 03:04:22PM -0500, Anthony Liguori wrote: > On 07/19/2011 02:23 PM, Richard W.M. Jones wrote: > >From: "Richard W.M. Jones" > > > >When using qemu -machine accel=kvm:tcg, if KVM is not available you > >get a load of debugging output: > > > > Could not access KVM kernel module: No such file or directory > > failed to initialize KVM: No such file or directory > > Back to tcg accelerator. > > If you ask for kvm, and it can't be initialized, then shouldn't we > alert the user about this? That's one way to look at it. Another is that libguestfs has specified that we want a "best effort". Give me KVM, if available - great! If not, I don't really care, give me TCG. The -machine option isn't expressive enough to say all these things of course. BTW, it seems in 0.15 that the -machine option is now required? eg in this case where it seems totally pointless: $ qemu -nographic -device \? KVM not supported for this target No accelerator found! This resulted in another bug and fix in libguestfs. http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=d82438431c1551610eb7d9945fa76d6387534582 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org