From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjPfQ-0004IF-43 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 01:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjPfL-0004lZ-Q8 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 01:49:56 -0400 Received: from ozlabs.org ([203.10.76.45]:60059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjPfL-0004l0-6p for qemu-devel@nongnu.org; Wed, 20 Jul 2011 01:49:51 -0400 Date: Wed, 20 Jul 2011 15:49:40 +1000 From: David Gibson Message-ID: <20110720054940.GF6399@yookeroo.fritz.box> References: <1311070524-13533-1-git-send-email-kwolf@redhat.com> <1311070524-13533-6-git-send-email-kwolf@redhat.com> <4E257BE6.7080108@codemonkey.ws> <1311081622.25044.423.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1311081622.25044.423.camel@pasglop> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/21] scsi: Add 'hba_private' to SCSIRequest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Kevin Wolf , qemu-devel@nongnu.org On Tue, Jul 19, 2011 at 11:20:22PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2011-07-19 at 07:43 -0500, Anthony Liguori wrote: > >=20 > > This breaks the build: > >=20 > > make[1]: Nothing to be done for `all'. > > CC ppc64-softmmu/spapr_vscsi.o > > /home/anthony/git/qemu/hw/spapr_vscsi.c: In function=20 > > =E2=80=98vscsi_command_complete=E2=80=99: > > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: error: =E2=80=98s=E2=80= =99 undeclared=20 > > (first use in this function) > > /home/anthony/git/qemu/hw/spapr_vscsi.c:535:34: note: each undeclared= =20 > > identifier is reported only once for each function it appears in > >=20 > > This file is only built when libfdt is installed which is probably > > why=20 > > you didn't catch it. > >=20 > > Ben/David, is there a way we can still build most of this stuff > > without=20 > > libfdt? libfdt is still not commonly packaged by some distros. >=20 > That would be hard ... the DT stuff is pretty deeply involved. Might be > easier to try to fix the distro :-) Actually, I think what we should do is embed libfdt into qemu. It's small, it will remove a bunch of irritating config dependencies, and it's designed to embeddable in this way. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other= _ | _way_ _around_! http://www.ozlabs.org/~dgibson