From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49577)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jamie@jamieiles.com>) id 1QjZHz-0006ZN-QV
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:06:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jamie@jamieiles.com>) id 1QjZHv-0005RD-6j
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:06:23 -0400
Received: from mail-wy0-f173.google.com ([74.125.82.173]:56607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jamie@jamieiles.com>) id 1QjZHu-0005Qz-UQ
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:06:19 -0400
Received: by wyf28 with SMTP id 28so305944wyf.4
	for <qemu-devel@nongnu.org>; Wed, 20 Jul 2011 09:06:17 -0700 (PDT)
Date: Wed, 20 Jul 2011 17:06:14 +0100
From: Jamie Iles <jamie@jamieiles.com>
Message-ID: <20110720160614.GF5109@pulham.picochip.com>
References: <CAFEAcA9CkF3uoZ4dF9etGcKZGdR+5CcgGF8h-DO9U1SJYdkbUg@mail.gmail.com>
	<1311078767-25177-1-git-send-email-jamie@jamieiles.com>
	<CAFEAcA-Kw4uXgLKBD8xjAv5fpKnddSoUR6YmjzDewJq-AkvZPQ@mail.gmail.com>
	<20110720153621.GC5109@pulham.picochip.com>
	<CAFEAcA88p=JnBZGUapCvexBhnTgT=+ztgmD+E_w1OcrYcH5YNw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA88p=JnBZGUapCvexBhnTgT=+ztgmD+E_w1OcrYcH5YNw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCHv2] target-arm: support for ARM1176JZF-s
	cores
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jamie Iles <jamie@jamieiles.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Paul Brook <paul@codesourcery.com>

On Wed, Jul 20, 2011 at 04:59:29PM +0100, Peter Maydell wrote:
> On 20 July 2011 16:36, Jamie Iles <jamie@jamieiles.com> wrote:
> > On Wed, Jul 20, 2011 at 03:35:19PM +0100, Peter Maydell wrote:
> >> On 19 July 2011 13:32, Jamie Iles <jamie@jamieiles.com> wrote:
> >> > Add support for v6K ARM1176JZF-S.  This core includes the VA<->PA
> >> > translation capability and security extensions.
> >>
> >> > +static uint32_t arm1176_cp15_c0_c1[8] =
> >> > +{ 0x111, 0x11, 0x33, 0x01130003, 0x01130003, 0x10030302, 0x01222100, 0 };
> >>
> >> This seems to be the wrong value for the AUXFR0 (0,c0,c1,3 : fourth item
> >> in this list). The 1176JZF-S TRM says its value is 0x0, not 0x01130003
> >> (which I think you've miscopied from the 0,c0,c1,4 MMFR0 entry).
> >
> > Ahh, yes.  Thanks for that, a good spot.
> 
> Thanks for the quick patch refresh. This version is
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> > 8<------
> 
> Incidentally, this is a bit of an unfortunate format for patches, as it
> doesn't apply with the usual "git am filename". Even if you add "-c" git
> still puts these headers:
> 
> > From af92ff0cd28077ff187f2ac1d952f71297b7d026 Mon Sep 17 00:00:00 2001
> > From: Jamie Iles <jamie@jamieiles.com>
> > Date: Thu, 23 Jun 2011 11:37:19 +0100
> > Subject: [PATCHv3] target-arm: support for ARM1176JZF-s cores
> 
> into the commit log.

Hmm, I misunderstood the scissors option, I guess a plain patch reply 
would have been best.

Thanks for the pointer (and Reviewed-by)!

Jamie