From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjZLO-0007c4-AZ for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:09:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QjZLM-00063x-HT for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:09:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QjZLM-00063o-53 for qemu-devel@nongnu.org; Wed, 20 Jul 2011 12:09:52 -0400 Date: Wed, 20 Jul 2011 19:10:18 +0300 From: "Michael S. Tsirkin" Message-ID: <20110720161018.GB8077@redhat.com> References: <4E25B85C.1030809@siemens.com> <4E25BB7A.7030105@redhat.com> <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com> <4E26BF77.7070705@siemens.com> <4E26C290.8010604@redhat.com> <4E26DECC.9000700@siemens.com> <4E26E716.2090109@redhat.com> <20110720143720.GC6787@redhat.com> <4E26EC22.1030309@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E26EC22.1030309@redhat.com> Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Jan Kiszka , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On Wed, Jul 20, 2011 at 05:54:26PM +0300, Avi Kivity wrote: > On 07/20/2011 05:37 PM, Michael S. Tsirkin wrote: > >> > >> If you do a memory_region_set_log() immediately after > >> memory_region_init_ram(), then as soon as the framebuffer is added > >> to the memory hierarchy, it will have logging enabled (or any > >> aliases of the framebuffer). > > > >Still, I think we should specify logging on/off when region is created, > >and avoid APIs that tweak dirty logging. > > It's the same thing. > > memory_region_init*(); > // we have a disconnected memory region > memory_region_set_log(); > // still disconnected, now logged > > I don't want memory_region_init() with 231 parameters. Pass in a struct then? > >I don't think there's actual need for device to enable/disable > >logging. > > Why not? migration does it, Yes but that's not a device. > and vga could do it if the vnc display > is disconnected, or if the update rate is so high it can just assume > all memory is dirty. Yes, but it's not something *devices* should be doing. > >What devices seem to need, instead, is enable/disable a region > >through a back channel. > > What do you mean? At least for qxl, all it seems to do is enable/disable logging when the region is enabled disabled. I'm not sure I follow what does vmware do - something similar only with a custom register instead of the standard memory enable? > -- > error compiling committee.c: too many arguments to function