From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33234)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QjaDS-0000mh-LG
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:05:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QjaDQ-0008EW-MQ
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:05:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11289)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1QjaDP-0008E5-RB
	for qemu-devel@nongnu.org; Wed, 20 Jul 2011 13:05:44 -0400
Date: Wed, 20 Jul 2011 20:06:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110720170608.GG8077@redhat.com>
References: <4E25BF26.6080900@siemens.com> <4E268E20.5050807@redhat.com>
	<4E26BF77.7070705@siemens.com> <4E26C290.8010604@redhat.com>
	<4E26DECC.9000700@siemens.com> <4E26E716.2090109@redhat.com>
	<20110720143720.GC6787@redhat.com> <4E26EC22.1030309@redhat.com>
	<20110720161018.GB8077@redhat.com> <4E2707C6.7060603@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E2707C6.7060603@redhat.com>
Subject: Re: [Qemu-devel] [RFC v4 00/58] Memory API
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>

On Wed, Jul 20, 2011 at 07:52:22PM +0300, Avi Kivity wrote:
> On 07/20/2011 07:10 PM, Michael S. Tsirkin wrote:
> >>  and vga could do it if the vnc display
> >>  is disconnected, or if the update rate is so high it can just assume
> >>  all memory is dirty.
> >
> >Yes, but it's not something *devices* should be doing.
> 
> No one knows about the frame buffer except the vga device.
> 
> >>  >What devices seem to need, instead, is enable/disable a region
> >>  >through a back channel.
> >>
> >>  What do you mean?
> >
> >At least for qxl, all it seems to do is enable/disable
> >logging when the region is enabled disabled.
> >I'm not sure I follow what does vmware do - something
> >similar only with a custom register instead of
> >the standard memory enable?
> 
> pv vga like vmware and qxl disables logging when the pv interface is active.

At least for qxl, logging seem to be disabled when region is
disabled:

    if (vga->map_addr && qxl->pci.io_regions[0].addr == -1)

-1 is a disabled region ...

> -- 
> error compiling committee.c: too many arguments to function