From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkSgd-0006N2-4q for qemu-devel@nongnu.org; Fri, 22 Jul 2011 23:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QkSgc-0003n1-BE for qemu-devel@nongnu.org; Fri, 22 Jul 2011 23:15:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QkSgb-0003mw-V8 for qemu-devel@nongnu.org; Fri, 22 Jul 2011 23:15:30 -0400 Date: Sat, 23 Jul 2011 08:45:16 +0530 From: Amit Shah Message-ID: <20110723031516.GC14493@amit-x200.redhat.com> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-1-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: > This patch series looks bigger than it is. All the patches are small > and hopefully easy to review. > > Objectives: > > * Push BlockDriverState members locked, tray_open, media_changed into > device models, where they belong. > > * BlockDriverState member removable is a confusing mess, replace it. > > * Improve eject -f. > > Also clean up minor messes as they get in the way. Sorry, haven't seen these patches yet, but a question: will adding things like 'this removable device is a CDROM/CD-RW/DVD/DVD-dual layer/DVD-dual-side/DVD-RAM, etc., need extra cleanups or will this just fit in? Amit