From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlKML-00046b-Na for qemu-devel@nongnu.org; Mon, 25 Jul 2011 08:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlKMK-0000kk-VC for qemu-devel@nongnu.org; Mon, 25 Jul 2011 08:34:09 -0400 Received: from verein.lst.de ([213.95.11.211]:46535 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlKMK-0000kg-QY for qemu-devel@nongnu.org; Mon, 25 Jul 2011 08:34:08 -0400 Date: Mon, 25 Jul 2011 14:34:08 +0200 From: Christoph Hellwig Message-ID: <20110725123408.GF12295@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-11-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-11-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 10/55] ide: Update command code definitions as per ACS-2 Table B.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:23:44PM +0200, Markus Armbruster wrote: > Drop WIN_SRST, it has same value as WIN_DEVICE_RESET. > > CFA_IDLEIMMEDIATE isn't specific to CFATA. ACS-2 shows it as a > defined command in ATA-1, -2 and -3. Rename to WIN_IDLEIMMEDIATE2. > > Turn unused macros into comments. I don't think that part is overly helpful. In general you'd want to keep all defines for protocol headers, just to make it easier to actually use them later on.