From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42111)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1QlLFp-0006Vq-Qx
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:31:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1QlLFo-0002GZ-1T
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:31:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gleb@redhat.com>) id 1QlLFn-0002GP-IG
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 09:31:28 -0400
Date: Mon, 25 Jul 2011 16:31:24 +0300
From: Gleb Natapov <gleb@redhat.com>
Message-ID: <20110725133124.GG4404@redhat.com>
References: <1311180636-17012-1-git-send-email-avi@redhat.com>
	<1311180636-17012-87-git-send-email-avi@redhat.com>
	<4E2D6A97.9050606@codemonkey.ws> <4E2D6C45.5030308@redhat.com>
	<20110725131728.GD4404@redhat.com> <4E2D6F6C.5070301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=cp1255
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <4E2D6F6C.5070301@redhat.com>
Subject: Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On Mon, Jul 25, 2011 at 04:28:12PM +0300, Avi Kivity wrote:
> On 07/25/2011 04:17 PM, Gleb Natapov wrote:
> >On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote:
> >>  On 07/25/2011 04:07 PM, Anthony Liguori wrote:
> >>  >On 07/20/2011 11:50 AM, Avi Kivity wrote:
> >>  >>The current implementation of PAM and the PCI holes is broken in se=
veral
> >>  >>ways:
> >>  >>
> >>  >>    - PCI BARs are not restricted to the PCI hole (a BAR may hide m=
emory)
> >>  >
> >>  >Technically, a BAR can be mapped to any non-RAM memory location.
> >>
> >>  I understood TOM (Top Of Memory) to be fixed - can't find a register
> >>  for it - but maybe I misread the spec.
> >>
> >PIIX3 spec:
> >
> >2.2.11.    TOM=97TOP OF MEMORY REGISTER (Function 0)
> >Address Offset:    69h
> >Default Value:     02h
> >Attribute:         Read/Write
> >
>=20
> What's it doing in PIIX3?  Is it the same TOM?
>=20
Good question. Looks like it is not:

This register enables the forwarding of ISA or DMA memory cycles to the
PCI Bus and sets the top of main
memory accessible by ISA or DMA devices. In addition, this register
controls the forwarding of ISA or DMA
accesses to the lower BIOS region (E0000=96EFFFFh) and the 512=96640-Kbyte
main memory region (80000=96
9FFFFh). The Top Of Memory configuration register must be set by the
BIOS.

--
			Gleb.