From: Amit Shah <amit.shah@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault
Date: Mon, 25 Jul 2011 21:19:38 +0530 [thread overview]
Message-ID: <20110725154938.GA31219@amit-x200.redhat.com> (raw)
In-Reply-To: <m3fwlu4fea.fsf@blackfin.pond.sub.org>
On (Mon) 25 Jul 2011 [16:13:33], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > 'balloon 0' in the monitor causes a segfault. This happens because
> > the function that handles change in balloon values is also tasked with
> > handling stats retrieval from the guest, and it does the retrieval
> > when the balloon target is '0'.
> >
> > Silly API, replace it. Also do a few cleanups along the way.
>
> Silly indeed.
>
> Consider explaining the crash in 5/7's commit message.
Thanks for the detailed comment; will add that to the changelog.
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks!
Amit
prev parent reply other threads:[~2011-07-25 15:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 8:35 [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 1/7] balloon: Make functions, local vars static Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 2/7] balloon: Add braces around if statements Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 3/7] balloon: Simplify code flow Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 4/7] virtio-balloon: Separate status handling into separate function Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling Amit Shah
2011-07-22 14:45 ` Markus Armbruster
2011-07-23 3:10 ` Amit Shah
2011-07-25 14:11 ` Markus Armbruster
2011-07-20 8:45 ` [Qemu-devel] [PATCH 6/7] balloon: Fix header comment; add Copyright Amit Shah
2011-07-20 8:45 ` [Qemu-devel] [PATCH 7/7] virtio-balloon: " Amit Shah
2011-07-25 14:13 ` [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault Markus Armbruster
2011-07-25 15:49 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725154938.GA31219@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).