From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QlNPe-0004ti-2G
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:49:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QlNPd-0007tF-5v
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:49:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50039)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1QlNPc-0007t8-TD
	for qemu-devel@nongnu.org; Mon, 25 Jul 2011 11:49:45 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6PFnhQJ029067
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 25 Jul 2011 11:49:43 -0400
Date: Mon, 25 Jul 2011 21:19:38 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110725154938.GA31219@amit-x200.redhat.com>
References: <cover.1311149456.git.amit.shah@redhat.com>
	<m3fwlu4fea.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3fwlu4fea.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>

On (Mon) 25 Jul 2011 [16:13:33], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> 
> > 'balloon 0' in the monitor causes a segfault.  This happens because
> > the function that handles change in balloon values is also tasked with
> > handling stats retrieval from the guest, and it does the retrieval
> > when the balloon target is '0'.
> >
> > Silly API, replace it.  Also do a few cleanups along the way.
> 
> Silly indeed.
> 
> Consider explaining the crash in 5/7's commit message.

Thanks for the detailed comment; will add that to the changelog.

> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks!

		Amit