From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlaGv-0008AE-Ux for qemu-devel@nongnu.org; Tue, 26 Jul 2011 01:33:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlaGu-0006xP-Ti for qemu-devel@nongnu.org; Tue, 26 Jul 2011 01:33:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlaGu-0006xA-F4 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 01:33:36 -0400 Date: Tue, 26 Jul 2011 11:03:29 +0530 From: Amit Shah Message-ID: <20110726053328.GA3067@amit-x200.redhat.com> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <20110723031516.GC14493@amit-x200.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, quintela@redhat.com, dbaryshkov@gmail.com, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On (Mon) 25 Jul 2011 [17:33:12], Markus Armbruster wrote: > Amit Shah writes: > > > On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: > >> This patch series looks bigger than it is. All the patches are small > >> and hopefully easy to review. > >> > >> Objectives: > >> > >> * Push BlockDriverState members locked, tray_open, media_changed into > >> device models, where they belong. > >> > >> * BlockDriverState member removable is a confusing mess, replace it. > >> > >> * Improve eject -f. > >> > >> Also clean up minor messes as they get in the way. > > > > Sorry, haven't seen these patches yet, but a question: will adding > > things like 'this removable device is a CDROM/CD-RW/DVD/DVD-dual > > layer/DVD-dual-side/DVD-RAM, etc., need extra cleanups or will this > > just fit in? > > I don't know, sorry. No problem! Amit