From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgGs-0008Hs-NZ for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:57:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlgGr-0006Rj-Hn for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:57:58 -0400 Received: from verein.lst.de ([213.95.11.211]:40453 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgGr-0006Rb-5m for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:57:57 -0400 Date: Tue, 26 Jul 2011 13:57:56 +0200 From: Christoph Hellwig Message-ID: <20110726115756.GA1418@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-13-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-13-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 12/55] ide: Fix ATA command READ to set ATAPI signature for CD-ROM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:23:46PM +0200, Markus Armbruster wrote: > Must set the ATAPI device signature, see ACS-2 7.36.6 Outputs for > PACKET feature set devices. Odd but true, even if it's 7.38.2 in my local copy of the ACS spec. It defintively should be documented in a comment next to the code, given how odd the behaviour is.