From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56036)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QlgHn-0001K8-27
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:58:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QlgHl-0006Z8-Us
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:58:55 -0400
Received: from verein.lst.de ([213.95.11.211]:40464 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QlgHl-0006Z4-PS
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:58:53 -0400
Date: Tue, 26 Jul 2011 13:58:53 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110726115853.GC1418@lst.de>
References: <1311179069-27882-1-git-send-email-armbru@redhat.com>
	<1311179069-27882-15-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1311179069-27882-15-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 14/55] ide: Reject ATA commands specific	to
	drive kinds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com

On Wed, Jul 20, 2011 at 06:23:48PM +0200, Markus Armbruster wrote:
> ACS-2 Table B.2 explicitly prohibits ATAPI devices from implementing
> WIN_RECAL, WIN_READ_EXT, WIN_READDMA_EXT, WIN_READ_NATIVE_MAX,
> WIN_MULTREAD_EXT, WIN_WRITE, WIN_WRITE_ONCE, WIN_WRITE_EXT,
> WIN_WRITEDMA_EXT, WIN_MULTWRITE_EXT, WIN_WRITE_VERIFY, WIN_VERIFY,
> WIN_VERIFY_ONCE, WIN_VERIFY_EXT, WIN_SPECIFY, WIN_MULTREAD,
> WIN_MULTWRITE, WIN_SETMULT, WIN_READDMA, WIN_READDMA_ONCE,
> WIN_WRITEDMA, WIN_WRITEDMA_ONCE, WIN_FLUSH_CACHE_EXT.  Restrict them
> to IDE_HD and IDE_CFATA.
> 
> Same for CFA_WRITE_SECT_WO_ERASE, CFA_WRITE_MULTI_WO_ERASE.  Restrict
> them to IDE_CFATA, like the other CFA_ commands.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>