From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgIl-0003Dh-Bf for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:59:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlgIk-0006i5-Bh for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:59:55 -0400 Received: from verein.lst.de ([213.95.11.211]:40473 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgIj-0006hf-UX for qemu-devel@nongnu.org; Tue, 26 Jul 2011 07:59:54 -0400 Date: Tue, 26 Jul 2011 13:59:53 +0200 From: Christoph Hellwig Message-ID: <20110726115953.GE1418@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-17-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-17-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 16/55] ide/atapi: Track tray open/close state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:23:50PM +0200, Markus Armbruster wrote: > We already track it in BlockDriverState since commit 4be9762a. As > discussed in that commit's message, we should track it in the device > device models instead, because it's device state. Looks good, Reviewed-by: Christoph Hellwig