From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:33924)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QlgLh-0005wd-3h
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:02:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1QlgLg-0007vA-76
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:02:57 -0400
Received: from verein.lst.de ([213.95.11.211]:36923 helo=newverein.lst.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1QlgLf-0007v6-VJ
	for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:02:56 -0400
Date: Tue, 26 Jul 2011 14:02:55 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20110726120255.GG1418@lst.de>
References: <1311179069-27882-1-git-send-email-armbru@redhat.com>
	<1311179069-27882-19-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1311179069-27882-19-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 18/55] scsi-disk: Reject CD-specific
	SCSI	commands to disks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com

On Wed, Jul 20, 2011 at 06:23:52PM +0200, Markus Armbruster wrote:
> Use a table to declare which drive kinds accept each command.
> 
> Limit READ_CAPACITY, READ_TOC, GET_CONFIGURATION to SCSI_CD, as per
> SPC-4.

READ CAPACITY is defined in SBC, and absolutely required for proper
operation with disks.