From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgSi-0002KU-G8 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:10:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlgSh-0000fo-CB for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:10:12 -0400 Received: from verein.lst.de ([213.95.11.211]:58429 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlgSh-0000fk-5h for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:10:11 -0400 Date: Tue, 26 Jul 2011 14:10:10 +0200 From: Christoph Hellwig Message-ID: <20110726121010.GJ1418@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-22-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-22-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 21/55] block: Revert entanglement of bdrv_is_inserted() with tray status List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com > @@ -1066,20 +1066,21 @@ static const struct { > [ 0x03 ] = { cmd_request_sense, ALLOW_UA }, > [ 0x12 ] = { cmd_inquiry, ALLOW_UA }, > [ 0x1a ] = { cmd_mode_sense, /* (6) */ 0 }, > - [ 0x1b ] = { cmd_start_stop_unit, 0 }, > + [ 0x1b ] = { cmd_start_stop_unit, 0 }, /* [1] */ > [ 0x1e ] = { cmd_prevent_allow_medium_removal, 0 }, > [ 0x25 ] = { cmd_read_cdvd_capacity, CHECK_READY }, > + /* [1] handler detects and reports not ready condition itself */ Why not comment this near the actual code? The footnote scheme is pretty odd and I've not seen it anywhere else in the code. Otherwise looks fine, Reviewed-by: Christoph Hellwig