From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlgak-0003D9-Rw for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlgaj-0002Ru-P5 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:18:30 -0400 Received: from verein.lst.de ([213.95.11.211]:54425 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlgaj-0002Ri-KX for qemu-devel@nongnu.org; Tue, 26 Jul 2011 08:18:29 -0400 Date: Tue, 26 Jul 2011 14:18:29 +0200 From: Christoph Hellwig Message-ID: <20110726121829.GU1418@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-40-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-40-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 39/55] block/raw: Fix to forward method bdrv_media_changed() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:24:13PM +0200, Markus Armbruster wrote: > Block driver "raw" forwards most methods to the underlying block > driver. However, it doesn't implement method bdrv_media_changed(). > Makes bdrv_media_changed() always return -ENOTSUP. > > I believe -fda /dev/fd0 gives you raw over host_floppy, and disk > change detection (fdc register 7 bit 7) is broken. Testing my theory > requires a computer museum, though. Haha. The patch looks fine to me anyway, Reviewed-by: Christoph Hellwig