From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhKj-0003um-VS for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:06:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlhKf-0003gK-DL for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:06:01 -0400 Received: from verein.lst.de ([213.95.11.211]:57242 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhKf-0003gF-7b for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:05:57 -0400 Date: Tue, 26 Jul 2011 15:05:57 +0200 From: Christoph Hellwig Message-ID: <20110726130556.GF2853@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-50-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-50-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: > Device models should be able to use it without an unclean include of > block_int.h. Hmm. We already do proper read-modify-write cycles for actual data transfers, so killing the buffer inside SD sounds like the better idea. qemu_blockalign really should be used only for block-layer internal allocations.