From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhME-0006U8-1k for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:07:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlhMD-00046O-6A for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:07:34 -0400 Received: from verein.lst.de ([213.95.11.211]:59869 helo=newverein.lst.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlhMD-00046J-1Z for qemu-devel@nongnu.org; Tue, 26 Jul 2011 09:07:33 -0400 Date: Tue, 26 Jul 2011 15:07:32 +0200 From: Christoph Hellwig Message-ID: <20110726130732.GI2853@lst.de> References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-53-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311179069-27882-53-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 52/55] block: Move BlockDriverAIOCB & friends from block_int.h to block.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com On Wed, Jul 20, 2011 at 06:24:26PM +0200, Markus Armbruster wrote: > Device models should be able to use them without an unclean include of > block_int.h. I don't think so. In generall they aren't for use of device models at all. It's just that the IDE trim support with it's ranges is rather "special". If you absolutely want IDE to stop including block_int.h I guess we'll have to lift that code into the block layer somehow.