From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlpgf-0000m6-1c for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qlpgd-00078V-Uo for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:01:12 -0400 Received: from mail.serverraum.org ([78.47.150.89]:45580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qlpgd-00078H-P1 for qemu-devel@nongnu.org; Tue, 26 Jul 2011 18:01:11 -0400 From: Michael Walle Date: Wed, 27 Jul 2011 00:01:09 +0200 References: <1311274344-8720-1-git-send-email-michael@walle.cc> In-Reply-To: <1311274344-8720-1-git-send-email-michael@walle.cc> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201107270001.09226.michael@walle.cc> Subject: Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori Cc: "Edgar E. Iglesias" Hi Anthony, could you please apply this patch to the 0.15 (and master) branch. Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle: > The QEMU keyboard and mouse reports themselves as full speed devices, > though they are actually low speed devices. Until this is fixed, claim that > we are supporting full speed devices. > > Signed-off-by: Michael Walle > --- > hw/milkymist-softusb.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c > index ce2bfc6..abf7b59 100644 > --- a/hw/milkymist-softusb.c > +++ b/hw/milkymist-softusb.c > @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev) > usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL); > > /* our two ports */ > + /* FIXME: claim to support full speed devices. qemu mouse and keyboard > + * report themselves as full speed devices. */ > usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops, > - USB_SPEED_MASK_LOW); > + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); > usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops, > - USB_SPEED_MASK_LOW); > + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); > > /* and finally create an usb keyboard */ > s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd"); -- Michael