* [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed
@ 2011-07-21 18:52 Michael Walle
2011-07-26 22:01 ` Michael Walle
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Michael Walle @ 2011-07-21 18:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Edgar E. Iglesias, Michael Walle
The QEMU keyboard and mouse reports themselves as full speed devices,
though they are actually low speed devices. Until this is fixed, claim that
we are supporting full speed devices.
Signed-off-by: Michael Walle <michael@walle.cc>
---
hw/milkymist-softusb.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
index ce2bfc6..abf7b59 100644
--- a/hw/milkymist-softusb.c
+++ b/hw/milkymist-softusb.c
@@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
/* our two ports */
+ /* FIXME: claim to support full speed devices. qemu mouse and keyboard
+ * report themselves as full speed devices. */
usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
- USB_SPEED_MASK_LOW);
+ USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
- USB_SPEED_MASK_LOW);
+ USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
/* and finally create an usb keyboard */
s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed
2011-07-21 18:52 [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed Michael Walle
@ 2011-07-26 22:01 ` Michael Walle
2011-08-01 21:44 ` [Qemu-devel] [0.15][PATCH] " Michael Walle
2011-08-03 13:17 ` [Qemu-devel] [PATCH] " Gerd Hoffmann
2 siblings, 0 replies; 5+ messages in thread
From: Michael Walle @ 2011-07-26 22:01 UTC (permalink / raw)
To: qemu-devel, Anthony Liguori; +Cc: Edgar E. Iglesias
Hi Anthony,
could you please apply this patch to the 0.15 (and master) branch.
Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> hw/milkymist-softusb.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
> usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
>
> /* our two ports */
> + /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> + * report themselves as full speed devices. */
> usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>
> /* and finally create an usb keyboard */
> s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");
--
Michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [0.15][PATCH] lm32: softusb: claim to support full speed
2011-07-21 18:52 [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed Michael Walle
2011-07-26 22:01 ` Michael Walle
@ 2011-08-01 21:44 ` Michael Walle
2011-08-03 13:17 ` [Qemu-devel] [PATCH] " Gerd Hoffmann
2 siblings, 0 replies; 5+ messages in thread
From: Michael Walle @ 2011-08-01 21:44 UTC (permalink / raw)
To: qemu-devel
Am Donnerstag 21 Juli 2011, 20:52:24 schrieb Michael Walle:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> hw/milkymist-softusb.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/milkymist-softusb.c b/hw/milkymist-softusb.c
> index ce2bfc6..abf7b59 100644
> --- a/hw/milkymist-softusb.c
> +++ b/hw/milkymist-softusb.c
> @@ -310,10 +310,12 @@ static int milkymist_softusb_init(SysBusDevice *dev)
> usb_bus_new(&s->usbbus, &softusb_bus_ops, NULL);
>
> /* our two ports */
> + /* FIXME: claim to support full speed devices. qemu mouse and keyboard
> + * report themselves as full speed devices. */
> usb_register_port(&s->usbbus, &s->usbport[0], NULL, 0, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
> usb_register_port(&s->usbbus, &s->usbport[1], NULL, 1, &softusb_ops,
> - USB_SPEED_MASK_LOW);
> + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL);
>
> /* and finally create an usb keyboard */
> s->usbdev = usb_create_simple(&s->usbbus, "usb-kbd");
Ping. Without this patch the whole milkymist target is non-functional in the
0.15 release.
--
Michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed
2011-07-21 18:52 [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed Michael Walle
2011-07-26 22:01 ` Michael Walle
2011-08-01 21:44 ` [Qemu-devel] [0.15][PATCH] " Michael Walle
@ 2011-08-03 13:17 ` Gerd Hoffmann
2011-08-03 23:36 ` Edgar E. Iglesias
2 siblings, 1 reply; 5+ messages in thread
From: Gerd Hoffmann @ 2011-08-03 13:17 UTC (permalink / raw)
To: Michael Walle; +Cc: Edgar E. Iglesias, qemu-devel
On 07/21/11 20:52, Michael Walle wrote:
> The QEMU keyboard and mouse reports themselves as full speed devices,
> though they are actually low speed devices. Until this is fixed, claim that
> we are supporting full speed devices.
>
> Signed-off-by: Michael Walle<michael@walle.cc>
For both master+stable:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed
2011-08-03 13:17 ` [Qemu-devel] [PATCH] " Gerd Hoffmann
@ 2011-08-03 23:36 ` Edgar E. Iglesias
0 siblings, 0 replies; 5+ messages in thread
From: Edgar E. Iglesias @ 2011-08-03 23:36 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Michael Walle, qemu-devel
On Wed, Aug 03, 2011 at 03:17:07PM +0200, Gerd Hoffmann wrote:
> On 07/21/11 20:52, Michael Walle wrote:
> >The QEMU keyboard and mouse reports themselves as full speed devices,
> >though they are actually low speed devices. Until this is fixed, claim that
> >we are supporting full speed devices.
> >
> >Signed-off-by: Michael Walle<michael@walle.cc>
>
> For both master+stable:
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Thanks, I've applied it to both master and stable-0.15.
Cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-03 23:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 18:52 [Qemu-devel] [PATCH] lm32: softusb: claim to support full speed Michael Walle
2011-07-26 22:01 ` Michael Walle
2011-08-01 21:44 ` [Qemu-devel] [0.15][PATCH] " Michael Walle
2011-08-03 13:17 ` [Qemu-devel] [PATCH] " Gerd Hoffmann
2011-08-03 23:36 ` Edgar E. Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).