From: "Michael S. Tsirkin" <mst@redhat.com>
To: aurelien@aurel32.net, zltjiangshi@gmail.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] vt82686b query
Date: Wed, 27 Jul 2011 11:31:20 +0300 [thread overview]
Message-ID: <20110727083120.GC15762@redhat.com> (raw)
Does one of you maintain the vt82686b emulation?
I was doing an overview of pci devices and have some questions on it:
vt82c686b_write_config - this seems to assume that
config writes are done using single byte accesses.
E.g. a two byte access at 0x84 will modify the
register at offset 0x85 but isn't handled by the
emulation. Is this intentional?
PCI_STATUS and PCI_CAPABILITY_LIST are initialized
in the reset callback. These are readonly so
should go into init - there's no guarantee
reset is invoked in time to set these correctly,
is there?
PCI_CAPABILITY_LIST is a single byte register.
Better set it using pci_set_byte or simple memory access?
Higer bytes in that word are reserved so zeroing them out is
harmless, but still ...
via_pm_info has a config write method that simply
invokes the pci_default_write_config directly -
makes sense to remove it and save some lines of code?
Will you be able to review/test patches addressing the above?
Thanks!
--
MST
reply other threads:[~2011-07-27 8:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727083120.GC15762@redhat.com \
--to=mst@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=zltjiangshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).