From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54541)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qlzpf-0006v2-LP
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 04:51:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qlzpe-0001EJ-Qq
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 04:51:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61027)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Qlzpe-0001EB-HD
	for qemu-devel@nongnu.org; Wed, 27 Jul 2011 04:51:10 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6R8p9Es004850
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 27 Jul 2011 04:51:09 -0400
Date: Wed, 27 Jul 2011 14:21:05 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110727085105.GA26136@amit-x200.redhat.com>
References: <cover.1311755243.git.amit.shah@redhat.com>
	<3c8905c75dbc9973eb9f0dd0823a0989ee2e12d1.1311755243.git.amit.shah@redhat.com>
	<20110727084344.GE15762@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110727084344.GE15762@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] virtio-net: Fix potential
	use-after-free
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On (Wed) 27 Jul 2011 [11:43:44], Michael S. Tsirkin wrote:
> On Wed, Jul 27, 2011 at 02:00:31PM +0530, Amit Shah wrote:
> > virtio_cleanup() will remove the VirtIONet struct that gets allocated
> > via virtio_common_init().  Ensure we don't dereference the structure
> > after calling the cleanup function.
> > 
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> 
> I see. It's not a use after free but will be once
> you make virtio_cleanup free the vdev?

Yes, the next patch.

		Amit