From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu list <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] Fix virtio memleaks
Date: Wed, 27 Jul 2011 12:08:52 +0300 [thread overview]
Message-ID: <20110727090852.GB31946@redhat.com> (raw)
In-Reply-To: <cover.1311755243.git.amit.shah@redhat.com>
On Wed, Jul 27, 2011 at 02:00:28PM +0530, Amit Shah wrote:
> The memory allocated in virtio_common_init() wasn't being freed
> anywhere. Fix that.
>
> The balloon handler wasn't unregistering its savevm section,
> adding an exit handler fixes that as well.
>
> This patchset is on top of the two balloon series I've sent out
> yesterday and today.
This looks good to me. What do you say I put
patches 2-4 on my tree, and you put patch 1 on yours?
> Amit Shah (4):
> virtio-balloon: Add exit handler, fix memleaks
> virtio-blk: Fix memleak on exit
> virtio-net: Fix potential use-after-free
> virtio: Plug memleak by freeing vdev
>
> hw/virtio-balloon.c | 9 +++++++++
> hw/virtio-blk.c | 1 +
> hw/virtio-net.c | 2 +-
> hw/virtio-pci.c | 11 ++++++++++-
> hw/virtio.c | 1 +
> hw/virtio.h | 1 +
> 6 files changed, 23 insertions(+), 2 deletions(-)
>
> --
> 1.7.6
>
next prev parent reply other threads:[~2011-07-27 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 8:30 [Qemu-devel] [PATCH 0/4] Fix virtio memleaks Amit Shah
2011-07-27 8:30 ` [Qemu-devel] [PATCH 1/4] virtio-balloon: Add exit handler, fix memleaks Amit Shah
2011-07-27 8:30 ` [Qemu-devel] [PATCH 2/4] virtio-blk: Fix memleak on exit Amit Shah
2011-07-27 9:07 ` Kevin Wolf
2011-07-27 8:30 ` [Qemu-devel] [PATCH 3/4] virtio-net: Fix potential use-after-free Amit Shah
2011-07-27 8:43 ` Michael S. Tsirkin
2011-07-27 8:51 ` Amit Shah
2011-07-27 8:30 ` [Qemu-devel] [PATCH 4/4] virtio: Plug memleak by freeing vdev Amit Shah
2011-07-27 9:08 ` Michael S. Tsirkin [this message]
2011-07-27 10:15 ` [Qemu-devel] [PATCH 0/4] Fix virtio memleaks Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727090852.GB31946@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).