From: "Daniel P. Berrange" <berrange@redhat.com>
To: Kenneth Salerno <kennethsalerno@yahoo.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc.
Date: Wed, 27 Jul 2011 16:56:31 +0100 [thread overview]
Message-ID: <20110727155631.GK7308@redhat.com> (raw)
In-Reply-To: <1311781823.44875.YahooMailClassic@web110409.mail.gq1.yahoo.com>
On Wed, Jul 27, 2011 at 08:50:23AM -0700, Kenneth Salerno wrote:
> Should check first if using a mingw compiler before forcing the addition of -lglib-2.0, -liconv, and -lintl to $LIBS of config-target.mak.
>
>
> Signed-off-by: Kenneth Salerno <kennethsalerno@yahoo.com>
> --- configure.ORIG 2011-07-27 11:28:16.859375000 -0400
> +++ configure 2011-07-27 11:43:59.859375000 -0400
> @@ -1824,9 +1824,11 @@
> # glib support probe
> if $pkg_config --modversion glib-2.0 > /dev/null 2>&1 ; then
> glib_cflags=`$pkg_config --cflags glib-2.0 2>/dev/null`
> - glib_libs=`$pkg_config --libs glib-2.0 2>/dev/null`
> - libs_softmmu="$glib_libs $libs_softmmu"
> - libs_tools="$glib_libs $libs_tools"
> + if test "$mingw32" != "yes" ; then
> + glib_libs=`$pkg_config --libs glib-2.0 2>/dev/null`
> + libs_softmmu="$glib_libs $libs_softmmu"
> + libs_tools="$glib_libs $libs_tools"
> + fi
This doesn't feel right to me. pkg-config works for mingw32 and should
be used just as it would be on native targets. What was the problem you
actually had without this change ?
If I had to guess I'd say your pkg-config program was not configured
to prefer mingw32 data files. You need to have an env var like this set
to make it pick up mingw32 rules instead of native ones:
export PKG_CONFIG_LIBDIR="/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig:/usr/i686-pc-mingw32/sys-root/mingw/share/pkgconfig" pkg-config
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2011-07-27 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 15:50 [Qemu-devel] [PATCH] MinGW compilation shouldn't include -lglib-2.0 etc Kenneth Salerno
2011-07-27 15:56 ` Daniel P. Berrange [this message]
2011-07-27 20:46 ` Kenneth Salerno
2011-07-27 20:50 ` Anthony Liguori
2011-07-27 21:13 ` Stefan Weil
2011-07-27 21:29 ` Kenneth Salerno
2011-07-27 21:27 ` [Qemu-devel] " Jernej Simončič
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110727155631.GK7308@redhat.com \
--to=berrange@redhat.com \
--cc=kennethsalerno@yahoo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).