From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmM9Z-00025T-6f for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmM9Y-00080U-2r for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:41:13 -0400 Received: from afflict.kos.to ([92.243.29.197]:52524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmM9X-000800-UJ for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:41:12 -0400 Date: Thu, 28 Jul 2011 11:41:09 +0300 From: Riku Voipio Message-ID: <20110728084109.GA20285@afflict.kos.to> References: <1311400070-9051-1-git-send-email-josch@pyneo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1311400070-9051-1-git-send-email-josch@pyneo.org> Subject: Re: [Qemu-devel] [PATCH] add QEMU_LD_PREFIX environment variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: josch Cc: stappers@stappers.nl, Riku Voipio , qemu-devel@nongnu.org, Johannes Schauer , 632192@bugs.debian.org On Sat, Jul 23, 2011 at 07:47:49AM +0200, josch wrote: > This could be avoided by setting the proposed environment variable > QEMU_LD_PREFIX to the just > created debian rootfs. As mentioned earlier, the usage of the -L option > is not possible in this scenario because qemu-user is only implicitly > called by the binfmt mechanism. What worries me here is that we are beginning to add a enviroment variable for each and every command line option of qemu linux-user. I think it would be better to have a wrapper binary to be registered as the binfmt runner. Alternatively we should have a generic setup for mapping enviroment variables to command line options. Now we get special per-option code every time someone needs to setup a command line option from binfmt. Riku