qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug
Date: Thu, 28 Jul 2011 11:49:04 +0300	[thread overview]
Message-ID: <20110728084904.GB4637@redhat.com> (raw)
In-Reply-To: <cover.1311833521.git.amit.shah@redhat.com>

On Thu, Jul 28, 2011 at 11:47:11AM +0530, Amit Shah wrote:
> Hello,
> 
> This series is on top of the other balloon series for which I sent a
> pull request on Tuesday.
> 
> This series fixes memleak on exit, unregisters the savevm section on
> unplug, disallows negative values as ballooning targets and doesn't
> allow multiple balloon device registrations.
> 
> v2 contains small tweaks suggested:
>  - Error is shown by balloon.c instead of virtio-balloon.c in patch 1
>    (mst)
>  - Filter out negative input in do_balloon() and add qerror message
>    (Markus)
>  - Separate out savevm section unregistering from memleak fix
> 
> 
> Amit Shah (5):
>   balloon: Don't allow multiple balloon handler registrations
>   virtio-balloon: Check if balloon registration failed
>   balloon: Ignore negative balloon values
>   virtio-balloon: Add exit handler, fix memleaks
>   virtio-balloon: Unregister savevm section on device unplug


Acked-by: Michael S. Tsirkin <mst@redhat.com>

>  balloon.c           |   20 +++++++++++++++++---
>  balloon.h           |    4 ++--
>  hw/virtio-balloon.c |   18 +++++++++++++++++-
>  hw/virtio-pci.c     |   14 +++++++++++++-
>  hw/virtio.h         |    1 +
>  5 files changed, 50 insertions(+), 7 deletions(-)
> 
> -- 
> 1.7.6

      parent reply	other threads:[~2011-07-28  8:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  6:17 [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug Amit Shah
2011-07-28  6:17 ` [Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations Amit Shah
2011-07-28  6:17 ` [Qemu-devel] [PATCH v2 2/5] virtio-balloon: Check if balloon registration failed Amit Shah
2011-07-28  6:17 ` [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values Amit Shah
2011-07-28  7:31   ` Markus Armbruster
2011-07-28  9:36     ` Amit Shah
2011-07-28  6:17 ` [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks Amit Shah
2011-07-28  6:28   ` Amit Shah
2011-07-28  7:39     ` Markus Armbruster
2011-07-28  9:37       ` Amit Shah
2011-07-28  7:35   ` Markus Armbruster
2011-07-28  6:17 ` [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug Amit Shah
2011-07-28  7:45   ` Markus Armbruster
2011-07-28  9:37     ` Amit Shah
2011-07-28 11:06     ` Michael S. Tsirkin
2011-07-28 12:21       ` Markus Armbruster
2011-07-28 12:27         ` Michael S. Tsirkin
2011-07-28  7:46 ` [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug Markus Armbruster
2011-07-28  8:49 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110728084904.GB4637@redhat.com \
    --to=mst@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).