From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmMGi-0003hM-9C for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:48:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmMGg-00018G-Rw for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:48:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmMGg-000185-Ae for qemu-devel@nongnu.org; Thu, 28 Jul 2011 04:48:34 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6S8mWtq030920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jul 2011 04:48:32 -0400 Date: Thu, 28 Jul 2011 11:49:04 +0300 From: "Michael S. Tsirkin" Message-ID: <20110728084904.GB4637@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list , Markus Armbruster On Thu, Jul 28, 2011 at 11:47:11AM +0530, Amit Shah wrote: > Hello, > > This series is on top of the other balloon series for which I sent a > pull request on Tuesday. > > This series fixes memleak on exit, unregisters the savevm section on > unplug, disallows negative values as ballooning targets and doesn't > allow multiple balloon device registrations. > > v2 contains small tweaks suggested: > - Error is shown by balloon.c instead of virtio-balloon.c in patch 1 > (mst) > - Filter out negative input in do_balloon() and add qerror message > (Markus) > - Separate out savevm section unregistering from memleak fix > > > Amit Shah (5): > balloon: Don't allow multiple balloon handler registrations > virtio-balloon: Check if balloon registration failed > balloon: Ignore negative balloon values > virtio-balloon: Add exit handler, fix memleaks > virtio-balloon: Unregister savevm section on device unplug Acked-by: Michael S. Tsirkin > balloon.c | 20 +++++++++++++++++--- > balloon.h | 4 ++-- > hw/virtio-balloon.c | 18 +++++++++++++++++- > hw/virtio-pci.c | 14 +++++++++++++- > hw/virtio.h | 1 + > 5 files changed, 50 insertions(+), 7 deletions(-) > > -- > 1.7.6